I’ve started using iCloud fully since they implemented end-to-end encryption, other than that I wouldn’t recommend keeping any (sensitive) data in the cloud if it’s not E2EE
I have iCloud+ on a family plan. Gives me Apple TV, Music, Fitness and 2TB of storage. I use it to back up all my photos (with a process to back them up to my local NAS as well as additional cloud storage - AWS Glacier)
I’m on a Mac all day and have an iPhone and iPad, so it works for me.
Some alternatives might be cheaper, but the integrations are too good to pass up.
I use my personal Dropbox account, but I also get free 5TB with Onedrive through work, and I’m paying a significant amount yearly ($180?) for 2TB through Dropbox. It may be time to switch, they aren’t so different I feel that the price is worth it to stick with Dropbox anymore.